Skip to content

[UR] Move non-conformance/adapter tests to lit #17580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

[UR] Move non-conformance/adapter tests to lit #17580

merged 1 commit into from
Apr 10, 2025

Conversation

RossBrunton
Copy link
Contributor

This adds support for lit to unified-runtime, in the form
of a new target check-unified-runtime. This target is available
when UR is built standalone and when built as part of dpcpp.

In addition, there are targets like check-unified-runtime-unit
which run a subset of the lit tests.

When built standalone, lit and filecheck must be avilable in
the path. A requirements_testing.txt file is available to
install test dependencies.

When built as part of dpcpp, a new cmake variable is available;
SYCL_UR_BUILD_TESTS which is off by default. When enabled,
check-unified-runtime will be available as a target and will
also run as part of check-all.

All tests have been ported with the exception of:

  • Adapter tests
  • Conformance tests

The Python version for macos was also bumped to 3.10 to enable
use of a newer filecheck version.

@RossBrunton RossBrunton marked this pull request as ready for review March 24, 2025 11:22
@RossBrunton RossBrunton requested review from a team as code owners March 24, 2025 11:22
@RossBrunton
Copy link
Contributor Author

#17361

This is a newer version of the PR here. See that for some comments that have hopefully been resolved.

aelovikov-intel
aelovikov-intel approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes outside unified-runtime LGTM.

aarongreig
aarongreig reviewed Mar 31, 2025
View reviewed changes
kbenzie
kbenzie reviewed Apr 4, 2025
View reviewed changes
unified-runtime/test/CMakeLists.txt
DEPENDS deps_check-unified-runtime
)
else()
add_lit_testsuite(check-unified-runtime "Running Unified Runtime ${suite} tests"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does add_lit_testing() come from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still interested in an answer to this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a function defined in intel/llvm. If a full LLVM build is available, we use the lit test suite managing thingies from there.

kbenzie
kbenzie approved these changes Apr 8, 2025
View reviewed changes
unified-runtime/test/CMakeLists.txt
DEPENDS deps_check-unified-runtime
)
else()
add_lit_testsuite(check-unified-runtime "Running Unified Runtime ${suite} tests"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still interested in an answer to this.

@RossBrunton
[UR] Move non-conformance/adapter tests to lit
f7ad045 
This adds support for lit to unified-runtime, in the form
of a new target `check-unified-runtime`. This target is available
when UR is built standalone and when built as part of dpcpp.

In addition, there are targets like `check-unified-runtime-unit`
which run a subset of the lit tests.

When built standalone, `lit` and `filecheck` must be avilable in
the path. A `requirements_testing.txt` file is available to
install test dependencies.

When built as part of dpcpp, a new cmake variable is available;
`SYCL_UR_BUILD_TESTS` which is off by default. When enabled,
`check-unified-runtime` will be available as a target and will
also run as part of `check-all`.

All tests have been ported with the exception of:
* Adapter tests
* Conformance tests

The Python version for macos was also bumped to 3.10 to enable
use of a newer filecheck version.
@RossBrunton
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge (unless there's a conflict due to someone updating tests).

@martygrant martygrant merged commit 585606a into intel:sycl Apr 10, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@aarongreig aarongreig aarongreig approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RossBrunton @kbenzie @aarongreig @aelovikov-intel @martygrant